Conversation
abnegate
reviewed
Apr 11, 2025
Contributor
Author
|
@abnegate here's a quick benchmark -
The controller froze on a CSV with 1,00,00,000 documents but I'll assume its way more than the last set. @abnegate |
abnegate
reviewed
Apr 14, 2025
eldadfux
previously requested changes
Apr 15, 2025
abnegate
reviewed
Apr 16, 2025
abnegate
reviewed
Apr 16, 2025
Member
abnegate
left a comment
abnegate
left a comment
There was a problem hiding this comment.
Let's add some tests as well
abnegate
reviewed
Apr 16, 2025
abnegate
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the CSV source handler.